daniel/Ryujinx
1
0
Fork 0
mirror of https://github.com/Ryujinx/Ryujinx.git synced 2025-06-28 21:00:47 -07:00
Code Issues Packages Projects Releases Wiki Activity

Strings should not be concatenated using '+' in a loop (#5664)

Browse Source 
* Strings should not be concatenated using '+' in a loop

* fix IDE0090

* undo GenerateLoadOrStore

* prefer string interpolation

* Update src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Instructions/InstGen.cs

Co-authored-by: Mary <thog@protonmail.com>

---------

Co-authored-by: Mary <thog@protonmail.com>
This commit is contained in:
Marco Carvalho
2023-10-05 07:41:00 -03:00
committed by GitHub
parent 0aceb534cb
commit 7835968214
12 changed files with 62 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/ARMeilleure/Diagnostics/Symbols.cs
View File

@ -1,6 +1,7 @@
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Diagnostics;
using System.Text;
namespace ARMeilleure.Diagnostics
{
@ -48,14 +49,15 @@ namespace ARMeilleure.Diagnostics
ulong diff = address - symbol.Start;
ulong rem = diff % symbol.ElementSize;
result = symbol.Name + "_" + diff / symbol.ElementSize;
StringBuilder resultBuilder = new();
resultBuilder.Append($"{symbol.Name}_{diff / symbol.ElementSize}");
if (rem != 0)
{
result += "+" + rem;
resultBuilder.Append($"+{rem}");
}
_symbols.TryAdd(address, result);
_symbols.TryAdd(address, resultBuilder.ToString());
return result;
}