general: Replace RESULT_SUCCESS with ResultSuccess

Transition to PascalCase for result names.

src/core/hle/service/am/applets/controller.h

@@ -129,7 +129,7 @@ private:
     ControllerSupportArgNew controller_user_arg_new;
     ControllerUpdateFirmwareArg controller_update_arg;
     bool complete{false};
-    ResultCode status{RESULT_SUCCESS};
+    ResultCode status{ResultSuccess};
     bool is_single_mode{false};
     std::vector<u8> out_data;
 };

src/core/hle/service/am/applets/error.cpp

@@ -135,7 +135,7 @@ bool Error::TransactionComplete() const {
 }
 
 ResultCode Error::GetStatus() const {
-    return RESULT_SUCCESS;
+    return ResultSuccess;
 }
 
 void Error::ExecuteInteractive() {

src/core/hle/service/am/applets/error.h

@@ -42,7 +42,7 @@ private:
     union ErrorArguments;
 
     const Core::Frontend::ErrorApplet& frontend;
-    ResultCode error_code = RESULT_SUCCESS;
+    ResultCode error_code = ResultSuccess;
     ErrorAppletMode mode = ErrorAppletMode::ShowError;
     std::unique_ptr<ErrorArguments> args;
 

src/core/hle/service/am/applets/general_backend.cpp

@@ -76,7 +76,7 @@ bool Auth::TransactionComplete() const {
 }
 
 ResultCode Auth::GetStatus() const {
-    return successful ? RESULT_SUCCESS : ERROR_INVALID_PIN;
+    return successful ? ResultSuccess : ERROR_INVALID_PIN;
 }
 
 void Auth::ExecuteInteractive() {
@@ -175,7 +175,7 @@ bool PhotoViewer::TransactionComplete() const {
 }
 
 ResultCode PhotoViewer::GetStatus() const {
-    return RESULT_SUCCESS;
+    return ResultSuccess;
 }
 
 void PhotoViewer::ExecuteInteractive() {
@@ -229,7 +229,7 @@ bool StubApplet::TransactionComplete() const {
 
 ResultCode StubApplet::GetStatus() const {
     LOG_WARNING(Service_AM, "called (STUBBED)");
-    return RESULT_SUCCESS;
+    return ResultSuccess;
 }
 
 void StubApplet::ExecuteInteractive() {

src/core/hle/service/am/applets/profile_select.cpp

@@ -23,7 +23,7 @@ ProfileSelect::~ProfileSelect() = default;
 
 void ProfileSelect::Initialize() {
     complete = false;
-    status = RESULT_SUCCESS;
+    status = ResultSuccess;
     final_data.clear();
 
     Applet::Initialize();

src/core/hle/service/am/applets/profile_select.h

@@ -51,7 +51,7 @@ private:
 
     UserSelectionConfig config;
     bool complete = false;
-    ResultCode status = RESULT_SUCCESS;
+    ResultCode status = ResultSuccess;
     std::vector<u8> final_data;
     Core::System& system;
 };

src/core/hle/service/am/applets/software_keyboard.cpp

@@ -658,7 +658,7 @@ void SoftwareKeyboard::InlineTextChanged() {
 
 void SoftwareKeyboard::ExitKeyboard() {
     complete = true;
-    status = RESULT_SUCCESS;
+    status = ResultSuccess;
 
     frontend.ExitKeyboard();
 

src/core/hle/service/am/applets/software_keyboard.h

@@ -160,7 +160,7 @@ private:
     bool is_background{false};
 
     bool complete{false};
-    ResultCode status{RESULT_SUCCESS};
+    ResultCode status{ResultSuccess};
 };
 
 } // namespace Service::AM::Applets

src/core/hle/service/am/applets/web_browser.h

@@ -68,7 +68,7 @@ private:
     const Core::Frontend::WebBrowserApplet& frontend;
 
     bool complete{false};
-    ResultCode status{RESULT_SUCCESS};
+    ResultCode status{ResultSuccess};
 
     WebAppletVersion web_applet_version{};
     WebArgHeader web_arg_header{};