Lioncash
16bf791939
yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()
...
Given the std::optional can contain an object type that heap allocates,
we can use std::move to avoid an unnecessary copy/allocation from
occurring.
2019-05-24 21:27:12 -04:00
Lioncash
b3d7180164
yuzu/applets/software_keyboard: Resolve sign mismatch comparison
...
Qt uses a signed value to represent container sizes, so this was causing
a sign mismatch warning.
2019-05-24 21:27:12 -04:00
Lioncash
cf9cc41478
yuzu/applets/software_keyboard: Specify string conversions explicitly
...
Allows the software keyboard applet code to compile with implicit string
conversions disabled.
2019-05-24 21:27:12 -04:00
Lioncash
f5d416e071
yuzu/applets/error: Specify string conversions explicitly
...
Allows the error applet to build successfully with implicit string
conversions disabled.
2019-05-24 21:27:12 -04:00
Lioncash
6f2a8fbb13
yuzu/main: Specify string conversions where applicable
2019-05-24 21:27:09 -04:00
Lioncash
f49a04ba39
yuzu/configuration/config: Make default hotkeys an internally-linked array in the cpp file
...
Given the array is a private static array, we can just make it
internally linked to hide it from external code. This also allows us to
remove an inclusion within the header.
2019-05-20 21:09:35 -04:00
Lioncash
938d6dca30
yuzu/configuration/config: Specify string conversions explicitly
...
Allows the configuration code to build successfully with implicit string
conversions disabled.
2019-05-20 21:08:32 -04:00
bunnei
9ffc60b5b3
Merge pull request #2455 from lioncash/config
...
configuration/config: Move config loading and saving to functions based off groups
2019-05-20 20:46:05 -04:00
Lioncash
bc32474901
yuzu/game_list: Specify string conversions explicitly
...
Allows the game list code to compile successfully with implicit string
conversions disabled.
2019-05-20 15:30:50 -04:00
Lioncash
ed2fedac13
yuzu/game_list_worker: Specify string conversions explicitly
...
Allows the game list worker code to compile successfully with implicit
string conversions disabled.
2019-05-20 15:07:59 -04:00
Lioncash
7a82d6f394
yuzu/game_list_p: Amend mentions of SMDH in comments
...
SMDH is a metadata format used in some executable formats for the
Nintendo 3DS. Switch executables don't utilize this metadata format, so
this just a holdover from Citra and can be corrected.
2019-05-20 15:04:35 -04:00
Lioncash
486c3e6085
yuzu/game_list_p: Specify string conversions explicitly
...
Allows the game list item code to build with implicit string conversions
disabled.
2019-05-20 15:02:37 -04:00
Lioncash
922d8c6cb4
yuzu/loading_screen: Specify string conversions explicitly
...
Allows the loading screen code to compile with implicit string
conversions disabled.
While we're at it remove unnecessary const usages, and add it to nearby
variables where appropriate.
2019-05-20 14:53:44 -04:00
Lioncash
fd34732e26
yuzu/bootmanager: Specify string conversions explicitly
...
Allows the bootmanager code to compile with implicit string conversions
disabled.
2019-05-20 14:50:53 -04:00
Lioncash
317f1263fb
yuzu/util: Specify string conversions explicitly
...
Allows the util code to build with implicit string conversions disabled.
2019-05-20 14:44:42 -04:00
Lioncash
2318c394a8
yuzu/configuration/configure_web: Specify string conversions explicitly
...
Allows the web config code to compile with implicit string conversions
disabled. We can also deduplicate the calls to create the pixmap.
2019-05-19 13:05:09 -04:00
Lioncash
d9c4d64ed5
yuzu/configuration/configure_system: Specify string conversions explicitly
...
Allows the system config code to build successfully with implicit string
conversions disabled.
2019-05-19 12:56:43 -04:00
Lioncash
428d8098a7
yuzu/configuration/configure_profile_manager: Mark UI string as translatable
...
This is a user-facing string, so it should be marked as translatable.
2019-05-19 12:54:04 -04:00
Lioncash
17255cd835
yuzu/configuration/configure_per_general: Specify string conversions explicitly
...
Allows the per-game configuration to be successfully built with implicit
string conversions disabled.
2019-05-19 12:47:33 -04:00
Lioncash
3039211c20
yuzu/configuration/configure_mouse_advanced: Clean up array accesses
...
Deduplicates array accesses and uses a named variable where appropriate.
2019-05-19 12:34:18 -04:00
Lioncash
c9c4208c4a
yuzu/configuration/configure_mouse_advanced: Specify string conversions explicitly
...
Allows the advanced mouse configuration code to build with implicit
string conversions disabled.
2019-05-19 12:34:18 -04:00
Lioncash
aa83639b78
yuzu/configuration/configure_input_player: Clean up array accesses
...
Rather than repeatedly index arrays that have quite a large array index,
we can just use a named variable instead.
2019-05-19 12:34:15 -04:00
Lioncash
4d2da5a40a
yuzu/configuration/configure_input_player: Specify string conversions explicitly
...
Allows the player input configuration code to compile with implicit
string conversions disabled.
2019-05-19 11:38:31 -04:00
Lioncash
d81d4a0f68
yuzu/configuration/configure_input: Mark controller type names as translateable
...
These are user-facing strings, so they should be localizable.
2019-05-19 11:23:25 -04:00
Lioncash
7e650088dd
yuzu/configuration/configure_general: Specify string conversions explicitly
...
Allows the general configuration code to successfully compile with
implicit string conversions disabled.
2019-05-19 11:18:16 -04:00
Lioncash
05235ccaa9
yuzu/configuration/configure_gamelist: Specify string conversions explicitly
...
Allows the gamelist configuration code to compile with implicit string
conversions disabled.
2019-05-19 11:16:23 -04:00
Lioncash
5f01ec338e
yuzu/configuration/configure_audio: Store power on query into a variable
...
Avoids using the system accessor more than necessary, and ensures that
both dialog boxes see the same power on state.
2019-05-19 11:12:31 -04:00
Lioncash
d00ca5c6c8
yuzu/configuration/configure_audio: Tidy up function cast
...
We can just use qOverload here to tidy up the function cast.
2019-05-19 11:10:58 -04:00
Lioncash
d184224e8f
yuzu/configuration/configure_audio: Specify string conversions explicitly
...
Allows the audio configuration code to build with implicit string
conversions disabled.
2019-05-19 11:08:56 -04:00
Hexagon12
ac3775e6ae
Merge pull request #2468 from lioncash/deduction
...
yuzu: Remove explicit types from locks where applicable
2019-05-19 15:05:56 +01:00
Hexagon12
209a0dfa35
Merge pull request #2492 from lioncash/debugger
...
yuzu/debugger: Specify string conversions explicitly
2019-05-19 14:49:54 +01:00
Sebastian Valle
27033de2e5
Merge pull request #2486 from lioncash/resetname
...
core/kernel/object: Rename ResetType enum members for clarity
2019-05-19 08:47:59 -05:00
Sebastian Valle
256e5c9583
Merge pull request #2493 from lioncash/translate
...
yuzu/applets/profile_select: Mark header string as translatable
2019-05-19 08:42:39 -05:00
Hexagon12
2437ca04d7
Merge pull request #2476 from ReinUsesLisp/fix-compat
...
yuzu/bootmanager: Explicitly enable deprecated OpenGL features on compat
2019-05-19 14:31:52 +01:00
Lioncash
bc6972caf9
yuzu/util: Remove unused spinbox.cpp/.h
...
This has been left unused since the removal of the vestigial surface
viewer. Given it has no uses left, this can be removed as well.
2019-05-19 05:35:34 -04:00
Lioncash
22324e3ef1
yuzu/applets/profile_select: Mark header string as translatable
...
This is a user-facing string, so it should be marked as translatable.
2019-05-19 01:18:37 -04:00
Lioncash
d77d1a0207
yuzu/debugger/graphics/graphics_breakpoints: Specify string conversions explicitly
...
Allows the graphics breakpoints to compile with implicit string
conversions disabled.
2019-05-19 01:10:05 -04:00
Lioncash
cad4f2ed29
yuzu/debugger/profiler: Specify string conversions explicitly
...
This allows the microprofile widget to compile with implicit string
conversions disabled.
2019-05-19 01:10:05 -04:00
Lioncash
a059b9eed4
yuzu/debugger/wait_tree: Specify string conversions explicitly
...
Allows compiling the wait tree widget with implicit string conversions
disabled.
2019-05-19 01:10:05 -04:00
Lioncash
a47aaa7f1b
core/kernel/object: Rename ResetType enum members
...
Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.
The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.
2019-05-18 15:52:51 -04:00
bunnei
fb85d5670d
Merge pull request #2457 from lioncash/about
...
yuzu/{about_dialog, main}: Specify string conversions explicitly for SCM-related info
2019-05-17 15:42:43 -04:00
ReinUsesLisp
4cf64f8e09
qt/configure_graphics: Shadow options at runtime
...
Compatibility profile and the disk shader cache settings shouldn't
be changed at runtime. This aims to address that shadowing those
options.
2019-05-17 04:29:20 -03:00
ReinUsesLisp
e6c60b419c
yuzu/bootmanager: Explicitly enable deprecated OpenGL features on compat
...
Nvidia's proprietary driver creates a real OpenGL compatibility profile
without this option, meanwhile Intel (and probably AMD, I haven't tested
it) require that QSurfaceFormat::FormatOption::DeprecatedFunctions is
explicitly enabled.
2019-05-17 04:09:17 -03:00
Lioncash
d6d809db87
yuzu: Remove explicit types from locks where applicable
...
With C++17's deduction guides, the type doesn't need to be explicitly
specified within locking primitives anymore.
2019-05-14 08:18:48 -04:00
bunnei
9567b3a293
Merge pull request #2458 from lioncash/hotkey
...
yuzu/hotkeys: Remove unnecessary constructor
2019-05-09 13:21:36 -04:00
bunnei
c6f3831320
Merge pull request #2456 from lioncash/qualifier
...
yuzu/compatdb: Remove unnecessary qualifiers
2019-05-09 13:21:04 -04:00
Lioncash
f3c18d622e
configure_dialog: Remove the Whats This? button from the dialog
2019-05-09 03:20:13 -04:00
Lioncash
8bdef4f951
yuzu/hotkeys: Remove unnecessary constructor
...
The behavior of the Hotkey constructor is already accomplished via in-class member
initializers, so the constructor is superfluous here.
2019-05-09 02:17:22 -04:00
Lioncash
d955944869
yuzu/main: Move window title updating logic to its own function
...
For similar reasons to the previous change, we move this to a single
function, so we don't need to duplicate the conversion logic in several
places within main.cpp.
2019-05-09 01:46:01 -04:00
Lioncash
bf1829a717
yuzu/about_dialog: Specify string conversions explicitly
...
Specifies the conversions explicitly to avoid implicit conversions from
const char* to QString. This makes it easier to disable implicit QString
conversions in the future.
In this case, the implicit conversion was technically wrong as well. The
implicit conversion treats the input strings as ASCII characters. This
would result in an incorrect conversion being performed in the rare case
a branch name was created with a non-ASCII Unicode character, likely
resulting in junk being displayed.
2019-05-09 01:18:37 -04:00