daniel/yuzu-android
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu-android synced 2024-12-28 05:01:20 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity
16,045 Commits 1 Branch 278 Tags 109 MiB
2b863c9aa3
Commit Graph

14121 Commits

Author SHA1 Message Date
bunnei
0c885249df
Merge pull request #4537 from lioncash/tz 
common/time_zone: Simplify GetOsTimeZoneOffset()
 2020-08-17 14:27:02 -04:00
bunnei
3472c00b3b
Merge pull request #4540 from lioncash/tr3 
configure_hotkeys: Don't translate empty strings
 2020-08-17 12:24:58 -04:00
bunnei
0530dd6ea1
Merge pull request #4494 from lioncash/transcode 
aes_util: Make use of non-template variant of Transcode
 2020-08-17 03:50:35 -04:00
Rodrigo Locatti
d8a90e6536
Merge pull request #4531 from lioncash/overload 
yuzu: Make use of qOverload where applicable
 2020-08-17 04:13:14 -03:00
David
cbaf1bc711
Merge pull request #4443 from ameerj/vk-async-shaders 
vulkan_renderer: Async shader/graphics pipeline compilation
 2020-08-17 15:06:11 +10:00
bunnei
bbb5623f52
Merge pull request #4515 from lat9nq/pgs-menubar-config 
main: Add an option to modify the currrent game's configuration
 2020-08-17 01:03:39 -04:00
David
a91acd5365
Merge pull request #4520 from lioncash/pessimize 
async_shaders: Resolve -Wpessimizing-move warning
 2020-08-17 14:36:05 +10:00
ameerj
fde8102a41 Remove unneeded newlines, optional Registry in shader params 
Addressing feedback from Rodrigo
 2020-08-16 16:33:21 -04:00
Ameer J
f49ffdd648 Morph: Update worker allocation comment 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-08-16 12:02:22 -04:00
ameerj
1b829fbd7a move thread 1/4 count computation into allocate workers method 2020-08-16 12:02:22 -04:00
ameerj
31a76410e8 Address feedback, add shader compile notifier, update setting text 2020-08-16 12:02:22 -04:00
ameerj
c02464f64e Vk Async Worker directly emplace in cache 2020-08-16 12:02:22 -04:00
ameerj
4539073ce1 Address feedback. Bruteforce delete duplicates 2020-08-16 12:02:22 -04:00
ameerj
6ac97405df Vk Async pipeline compilation 2020-08-16 12:02:22 -04:00
David Marcec
80ac1331b5 Preliminary effects 2020-08-17 01:23:55 +10:00
MerryMage
836ec9176a dynarmic: Add unsafe optimizations 2020-08-16 14:15:39 +01:00
Lioncash
e23289d869 configure_hotkeys: Don't translate empty strings 
There's no need to translate an empty string. This just gives
translators unnecessary work.
 2020-08-16 08:13:25 -04:00
Lioncash
c4ed791164 common/fileutil: Convert namespace to Common::FS 
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.

This also allows for high-traffic FS related code to alias the
filesystem function namespace as

namespace FS = Common::FS;

for more concise typing.
 2020-08-16 06:52:40 -04:00
Lioncash
d09456fc41 common: Silence two discarded result warnings 
These are intentionally discarded internally, since the rest of the
public API allows querying success. We want all non-internal uses of
these functions to be explicitly checked, so we can signify that we
intentionally want to discard the return values here.
 2020-08-16 06:17:33 -04:00
Lioncash
fe97d34156 common/time_zone: Simplify GetOsTimeZoneOffset() 
We can simplify this function down into a single line with the use of
fmt. A benefit with the fmt approach is that the fmt variant of
localtime is thread-safe as well, making GetOsTimeZoneOffset()
thread-safe as well.
 2020-08-16 03:58:47 -04:00
Lioncash
dbb1cbce67 yuzu: Resolve -Wextra-semi warnings 
While we're in the same area, we can ensure GameDir member variables are
always initialized to consistent values.
 2020-08-16 03:58:29 -04:00
bunnei
db96034ea4
Merge pull request #4528 from lioncash/discard 
common: Make use of [[nodiscard]] where applicable
 2020-08-16 01:47:54 -04:00
bunnei
404362e1b0
Merge pull request #4519 from lioncash/semi 
maxwell_3d: Resolve -Wextra-semi warning
 2020-08-16 00:55:15 -04:00
lat9nq
9f972b7d01 main: Add an option to modify the currrent game's configuration 
Creates a new entry in the Emulation menu called "Configure Current Game..." that is only available if a game is currently being executed in yuzu. When selected, it opens the game properties dialog for the current game.

Thanks to @BSoDGamingYT for reminding me to do this.
 2020-08-15 20:28:48 -04:00
Lioncash
1ee060ca0d common/compression: Roll back std::span changes 
Seems like all compilers don't support std::span yet.
 2020-08-15 17:17:56 -04:00
Lioncash
df72480395 common: Make use of [[nodiscard]] where applicable 
Now that clang-format makes [[nodiscard]] attributes format sensibly, we
can apply them to several functions within the common library to allow
the compiler to complain about any misuses of the functions.
 2020-08-15 17:17:52 -04:00
bunnei
2b601e8636
Merge pull request #4526 from lioncash/core-semi 
core: Resolve several -Wextra-semi warnings
 2020-08-15 02:14:11 -04:00
bunnei
e6f9231ef0
Merge pull request #4527 from lioncash/pessimizing2 
software_keyboard: Resolve a pessimizing move warning
 2020-08-15 02:13:44 -04:00
bunnei
cb6808b4d0
Merge pull request #4492 from lioncash/linkage 
system_control: Make functions internally linked where applicable
 2020-08-15 02:11:49 -04:00
bunnei
2aabd1eb05
Merge pull request #4463 from lioncash/lockdiscard 
kernel/scheduler: Mark SchedulerLock constructor as nodiscard
 2020-08-15 01:31:23 -04:00
bunnei
feb243b08d
Merge pull request #4416 from lioncash/span 
lz4_compression/zstd_compression: Make use of std::span in interfaces
 2020-08-15 00:53:11 -04:00
bunnei
2dace90346
Merge pull request #4453 from ReinUsesLisp/block-to-linear 
textures/decoders: Fix block linear to pitch copies
 2020-08-14 19:52:12 -04:00
Lioncash
fe86109877 configuration_shared: Simplify name lookup in highlighting functions 
We can query the given object name directly from the widget itself. This
removes any potential for forgetting to change the name if the widget
gets renamed and makes the API much simpler (just pass in the widget,
and not worry about its name).
 2020-08-14 14:17:02 -04:00
Lioncash
969a4cc4da yuzu: Make use of qOverload where applicable 
Eliminates a verbose function cast.
 2020-08-14 14:12:55 -04:00
Lioncash
b14277ef97 time_zone_content_manager: Collapse auto and default case 
Prevents a useless self-assignment from occurring.
 2020-08-14 10:58:58 -04:00
David Marcec
1f1c3bddc0 Disable biquad filter 2020-08-14 23:20:20 +10:00
Lioncash
03d5a5d9de software_keyboard: Resolve a pessimizing move warning 
A std::vector created in place like this is already an rvalue and
doesn't need to be moved.
 2020-08-14 09:14:54 -04:00
Lioncash
2296e921d2 core: Resolve several -Wextra-semi warnings 
We can amend one of the cascade macros to require semicolons in order to
compile. In other cases, we can just remove the superfluous semicolons.
 2020-08-14 09:09:20 -04:00
Lioncash
dcc5562cd5 shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message 
We need to provide a message for this variant of the macro, so we can
simply log out the type being used.
 2020-08-14 08:38:37 -04:00
Lioncash
34ec64233a macro-interpreter: Resolve -Wself-assign-field warning 
This was assigning the field to itself, which is a no-op. The size
doesn't change between its initial assignment and this one, so this is a
safe change to make.
 2020-08-14 08:26:50 -04:00
Lioncash
167d36ec3c vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties() 
Given this is implicitly creating a std::optional, we can move the
vector into it.
 2020-08-14 08:23:49 -04:00
Lioncash
c8135b3c18 gl_shader_disk_cache: Make use of std::nullopt where applicable 
Allows the compiler to avoid unnecessarily zeroing out the internal
buffer of std::optional on some implementations.
 2020-08-14 08:20:44 -04:00
Lioncash
6b13d08822 async_shaders: Resolve -Wpessimizing-move warning 
Prevents pessimization of the move constructor (which thankfully didn't
actually happen in practice here, given std::thread isn't copyable).
 2020-08-14 08:16:50 -04:00
Lioncash
83d8bf9af9 maxwell_3d: Resolve -Wextra-semi warning 
Semicolons after a function definition aren't necessary.
 2020-08-14 08:13:41 -04:00
David Marcec
1b3d86c02f Reworked ADPCM decoder to allow better streaming 2020-08-14 21:04:28 +10:00
Lioncash
a93f6e51d3 emu_window: Mark Scoped constructor and Acquire() as nodiscard 
Ensures that callers make use of the constructor, preventing bugs from
silently occurring.
 2020-08-14 04:43:44 -04:00
Lioncash
f808258ed9 kernel/scheduler: Mark SchedulerLock constructor as nodiscard 
Allows the compiler to warn about cases where the constructor is used
but then immediately discarded, which is a potential cause of
locking/unlocking bugs.
 2020-08-14 04:43:44 -04:00
Rodrigo Locatti
e050594706
Merge pull request #4495 from lioncash/conv 
cheat_engine: Resolve implicit bool->u64 conversion
 2020-08-14 03:10:17 -03:00
bunnei
a9de967fa3
Merge pull request #4514 from Morph1984/worker-alloc 
gl_shader_cache: Use std::max() for determining num_workers
 2020-08-13 17:06:57 -04:00
LC
ff0b14ee62
Merge pull request #4511 from lioncash/build2 
General: Tidy up clang-format warnings part 2
 2020-08-13 15:13:21 -04:00
Lioncash
b724a4d90c General: Tidy up clang-format warnings part 2 2020-08-13 14:19:08 -04:00
Morph
e0ff98dd34 gl_shader_cache: Use std::max() for determining num_workers 
Does not allocate more threads than available in the host system for boot-time shader compilation and always allocates at least 1 thread if hardware_concurrency() returns 0.
 2020-08-12 09:23:34 -04:00
bunnei
a8ffe6eee4
Merge pull request #4497 from lioncash/freezer-alg 
freezer: Make use of std::erase_if
 2020-08-11 23:07:17 -04:00
bunnei
e143adc3cf
Merge pull request #4493 from jbeich/dragonfly 
common/virtual_buffer: drop unused includes
 2020-08-11 12:52:50 -04:00
bunnei
4605e4d6ff
Merge pull request #4502 from lioncash/build 
General: Tidy up clang-format warnings
 2020-08-11 11:04:05 -04:00
ReinUsesLisp
f00641459e textures/decoders: Fix block linear to pitch copies 
There were two issues with block linear copies. First the swizzling was
wrong and this commit reimplements them.

The other issue was that these copies are generally used to download
render targets from the GPU and yuzu was not downloading them from
host GPU memory unless the extreme GPU accuracy setting was selected.
This commit enables cached memory reads for all accuracy levels.

- Fixes level thumbnails in Super Mario Maker 2.
 2020-08-10 20:45:03 -03:00
bunnei
257b1d2c4b
Merge pull request #4496 from lioncash/ce-desig 
cheat_engine: Make use of designated initializers
 2020-08-10 13:53:43 -04:00
ameerj
d6672501ac Remove UI changes 
This PR is now only the Analog devices handling the range value defaulting at 100%
 2020-08-10 12:46:14 -04:00
ameerj
9c6ae697f5 Add range slider functionality for gc adapter 2020-08-10 12:46:14 -04:00
Ameer
8928aa3008 undo unnecessary newlines, slider range 50-150 2020-08-10 12:46:14 -04:00
Ameer
504095cea9 Address c++20 warning, fix inaccurate range text display when slide == 0 2020-08-10 12:46:14 -04:00
Ameer
ed51c2abda Add range slider for analog sticks 2020-08-10 12:46:14 -04:00
bunnei
acfd771e79
Merge pull request #4491 from lioncash/unused-vars 
kernel: Remove unused variables
 2020-08-10 12:04:30 -04:00
bunnei
664019954a
Merge pull request #4488 from lioncash/file 
vfs_vector: Make creation of array vfs files less verbose
 2020-08-09 17:19:34 -04:00
Lioncash
1c3490a8db General: Tidy up clang-format warnings 2020-08-08 20:08:44 -04:00
bunnei
f14bb61acd
Merge pull request #4448 from Morph1984/fix-entries 
game_list_worker: Do not clear entries when > 1 gamedir is present
 2020-08-07 17:11:52 -04:00
bunnei
929fc849e9
Merge pull request #4457 from ogniK5377/SetScreenShotPermission 
am: Unstub SetScreenShotPermission
 2020-08-07 09:34:20 -04:00
bunnei
5429ea0e69
Merge pull request #4389 from ogniK5377/redundant-format-type 
video_core: Remove redundant pixel format type
 2020-08-07 09:33:58 -04:00
Lioncash
8e86fa7e60 common/concepts: Rename IsBaseOf to DerivedFrom 
This makes it more inline with its currently unavailable standardized
analogue std::derived_from.

While we're at it, we can also make the template match the requirements
of the standardized variant as well.
 2020-08-07 08:09:57 -04:00
bunnei
f5d538f118
Merge pull request #4483 from lioncash/constexpr-hex 
partition_data_manager: Make data arrays constexpr
 2020-08-06 23:14:14 -04:00
bunnei
5cc2f99fab
Merge pull request #4490 from lioncash/arbiter 
address_arbiter/scheduler: Resolve sign conversion warnings
 2020-08-06 22:28:11 -04:00
Lioncash
61cd7eb47d freezer: Move entry finding to its own function 
Cleans up the callsites in other functions.
 2020-08-06 03:11:21 -04:00
Lioncash
06ab28263b freezer: Take address values by value 
VAddr will always be 64-bit, so there's no need to take a trivial
primitive alias by reference.
 2020-08-06 03:04:54 -04:00
Lioncash
253a17451b freezer: Make use of std::erase_if 
With C++20 we can simplify the erasing idiom.
 2020-08-06 03:03:05 -04:00
Lioncash
5b89291308 cheat_engine: Resolve implicit bool->u64 conversion 
We can just return zero here.
 2020-08-06 02:55:47 -04:00
Lioncash
df96a214ae cheat_engine: Make use of designated initializers 
Same behavior, but makes the member being assigned obvious.
 2020-08-06 02:48:13 -04:00
Lioncash
4f2acc54f5 partition_data_manager: Update master key hashes 
Fills in some hashes that were previously unhandled.
 2020-08-06 02:42:01 -04:00
Lioncash
7f0f37fca7 partition_data_manager: Make data arrays constexpr 
Previously the constructor for all of these would run at program
startup, consuming time before the application can enter main().

This is also particularly dangerous, given the logging system wouldn't
have been initialized properly yet, yet the program would use the logs
to signify an error.

To rectify this, we can replace the literals with constexpr functions
that perform the conversion at compile-time, completely eliminating the
runtime cost of initializing these arrays.
 2020-08-06 02:41:58 -04:00
Lioncash
04bb47f57f partition_data_manager: Eliminate magic value 
We can use sizeof to make it obvious at the call site where the value is
coming from.
 2020-08-06 02:34:10 -04:00
Lioncash
09f884b7bd aes_util: Make use of non-template variant of Transcode 
Same behavior, less template instantiations.
 2020-08-06 02:31:19 -04:00
comex
d37f0b29e2 Fix thread naming on Linux, which limits names to 15 bytes. 
- In `SetCurrentThreadName`, when on Linux, truncate to 15 bytes, as (at
  least on glibc) `pthread_set_name_np` will otherwise return `ERANGE` and
  do nothing.
- Also, add logging in case `pthread_set_name_np` returns an error
  anyway.  This is Linux-specific, as the Apple and BSD versions of
  `pthread_set_name_np return `void`.
- Change the name for CPU threads in multi-core mode from
  "yuzu:CoreCPUThread_N" (19 bytes) to "yuzu:CPUCore_N" (14 bytes) so it
  fits into the Linux limit.  Some other thread names are also cut off,
  but I didn't bother addressing them as you can guess them from the
  truncated versions.  For a CPU thread, truncation means you can't see
  which core it is!
 2020-08-05 20:34:49 -07:00
bunnei
1cc0e4b4d8
Merge pull request #4489 from lioncash/typesafe 
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
 2020-08-05 23:20:23 -04:00
bunnei
35c1607f23
Merge pull request #4484 from lioncash/aesutil 
aes_util: Allow SetIV() to be non-allocating
 2020-08-05 22:35:41 -04:00
bunnei
d888ac7d20
Merge pull request #4477 from lioncash/log-desig 
logging/backend: Make use of designated initializers
 2020-08-05 22:34:12 -04:00
Jan Beich
238208ee30 common/virtual_buffer: drop unused includes 
On DragonFly and NetBSD build fails with

src/common/virtual_buffer.cpp
src/common/virtual_buffer.cpp:16:10: fatal error: sys/sysinfo.h: No such file or directory
 #include <sys/sysinfo.h>
          ^~~~~~~~~~~~~~~
 2020-08-05 21:36:35 +00:00
bunnei
61678c4e9f
Merge pull request #4475 from lioncash/bqueue 
buffer_queue: Make use of designated initializers/std::nullopt where applicable
 2020-08-05 16:56:46 -04:00
bunnei
e8868c2ed1
Merge pull request #4479 from lioncash/concepts 
CMakeLists: Resolve #4478
 2020-08-05 16:18:08 -04:00
Lioncash
87c64c41d2 system_control: Make functions internally linked where applicable 
These functions are only ever used internally as implementation details
for GenerateRandomRange(), so these can be given internal linkage.
 2020-08-05 15:34:27 -04:00
Lioncash
a10d64ea79 kernel: Remove unused variables 
Resolves a few compiler warnings.
 2020-08-05 15:19:48 -04:00
Lioncash
9893da8e2c scheduler: Resolve sign conversion warning 2020-08-05 15:12:29 -04:00
Lioncash
1a45b15a8c address_arbiter: Resolve sign conversion warning 
Makes our type conversion explicit.
 2020-08-05 15:07:19 -04:00
bunnei
4a2d9c6454
Merge pull request #4444 from lioncash/volatile 
common/atomic_ops: Don't cast away volatile from pointers
 2020-08-05 14:22:36 -04:00
Lioncash
a77ee63f65 ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw() 
It's undefined behavior to use non-trivially copyable objects with
std::memcpy, so we can add asserts to catch usages of these at
compile-time.
 2020-08-05 14:08:28 -04:00
Lioncash
0a5456feb9 vfs_vector: Make creation of array vfs files less verbose 
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.

e.g. The timezone location names are 9633 bytes in size.
 2020-08-05 12:37:00 -04:00
bunnei
07691f994a
Merge pull request #4466 from ogniK5377/loader-type-safe 
loader: Make IdentifyFile typesafe
 2020-08-05 12:34:25 -04:00
Morph
cf946312ca main: Fallback to loader if no control nca is found with patch manager 
In some rare instances, the patch manager is not able to find a control nca, fallback to the previous method of parsing a control nca through the loader if this occurs.
 2020-08-04 21:14:20 -04:00
Morph
1146049de0 main: Fix Open Save/Mod Locations for installed titles 
Previously NAND/SDMC installed titles would open device saves when they are supposed to be user saves. This is due to the control nca not being read and thus returns 0 for both GetDefaultNormalSaveSize() and GetDeviceSaveDataSize(). Fix this by utilizing the patch manager to read the control nca.
 2020-08-04 21:14:20 -04:00
Morph
123024cea2 game_list_worker: Do not clear entries when > 1 gamedir is present 
Previously the map of entries was being cleared while looping through each game directory, this resulted into all game directories except the last game dir to lose content metadata information. Fix this by clearing the entries only once.
 2020-08-04 21:13:35 -04:00
bunnei
142930e609
Merge pull request #4476 from lioncash/tz 
time_zone_binary: Make use of designated initializers
 2020-08-04 18:56:28 -04:00
bunnei
ba9ed7b1fe
Merge pull request #4401 from ogniK5377/GetIndirectLayerImageRequiredMemoryInfo 
vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo
 2020-08-04 18:45:11 -04:00
bunnei
f11628b9b7
Merge pull request #4430 from bunnei/new-gpu-vmm 
hle: nvdrv: Rewrite of GPU memory management.
 2020-08-04 18:44:26 -04:00
bunnei
efd1b57d03
Merge pull request #4445 from Morph1984/async-threads 
renderer_opengl: Use 1/4 of all threads for async shader compilation
 2020-08-04 18:43:42 -04:00
bunnei
c71d05de84
Merge pull request #4450 from Morph1984/fix-gamelist-scanning 
game_list_worker: Fix game list subdirectory scanning
 2020-08-04 18:43:17 -04:00
bunnei
ecbee11829
Merge pull request #4472 from lioncash/const-get 
perf_stats: Mark GetMeanFrametime() as const
 2020-08-04 07:00:23 -07:00
bunnei
0ae267bf77
Merge pull request #4469 from lioncash/missing 
vk_texture_cache: Silence -Wmissing-field-initializer warnings
 2020-08-04 06:59:51 -07:00
David
741cbbdc0e
Merge pull request #4470 from lioncash/qualifier 
patch_manager: Resolve -Wignored-qualifier warnings
 2020-08-04 14:09:48 +10:00
David
723314b682
Merge pull request #4481 from lioncash/cpp-dep 
yuzu: Resolve C++20 deprecation warnings related to lambda captures
 2020-08-04 14:06:07 +10:00
David
25fb7cd16d
Merge pull request #4474 from lioncash/hle-profile 
profile_manager: Make use of designated initializers
 2020-08-04 13:51:15 +10:00
bunnei
c6e5a36452
Merge pull request #4473 from lioncash/cheat-desig 
dmnt_cheat_vm: Make use of designated initializers
 2020-08-03 18:07:17 -07:00
bunnei
0dbb95c42d
Merge pull request #4456 from Morph1984/stub-really-long-fs-func 
fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute
 2020-08-03 18:06:48 -07:00
Lioncash
15660bd857 aes_util: Allow SetIV to be non-allocating 
In a few places, the data to be set as the IV is already within an array.
We shouldn't require this data to be heap-allocated if it doesn't need
to be. This allows certain callers to reduce heap churn.
 2020-08-03 14:29:58 -04:00
bunnei
b2911421ec
Merge pull request #4480 from lioncash/optimize 
tests/core_timing: Remove pragma optimize(off)
 2020-08-03 11:27:52 -07:00
bunnei
9808f244cc
Merge pull request #4482 from lioncash/ldr-sign 
service/ldr: Resolve sign mismatch warnings
 2020-08-03 11:27:13 -07:00
bunnei
a971667d1f
Merge pull request #4468 from lioncash/regcache 
registered_cache: Resolve -Wmaybe_uninitialized warnings
 2020-08-03 11:26:45 -07:00
bunnei
94c1689ef3
Merge pull request #4471 from ogniK5377/sm-getservice-concept 
sm: Make use of IsBaseOf for GetService
 2020-08-03 11:11:22 -07:00
Lioncash
570150bc86 perf_stats: Make use of designated initializers 
Same behavior, but allows us to avoid a now-unnecessary zero
initialization.
 2020-08-03 12:33:40 -04:00
Lioncash
d767be65be perf_stats: Mark GetMeanFrametime() as const 
The general pattern is to mark mutexes as mutable when it comes to
matters of constness, given the mutex acts as a transient member of a
data structure.
 2020-08-03 12:33:35 -04:00
Lioncash
06809ad7bc vulkan: Silence more -Wmissing-field-initializer warnings 2020-08-03 12:28:57 -04:00
Lioncash
b249e4e0ce yuzu: Resolve C++20 deprecation warnings related to lambda captures 
C++20 deprecates capturing the this pointer via the '=' capture.
Instead, we replace it or extend the capture specification.
 2020-08-03 11:54:04 -04:00
Lioncash
f525da56e5 service/ldr: Resolve sign mismatch warnings 
We were performing an int < size_t comparison. We can just correct the
type of the induction variable.
 2020-08-03 11:48:16 -04:00
Lioncash
dd2ff23621 CMakeLists: Resolve #4478 
This switch is enabled by default in all recent versions of GCC and
Clang.
 2020-08-03 11:21:24 -04:00
Lioncash
e1ab72a0ea tests/core_timing: Remove pragma optimize(off) 
I made a review comment about this in the PR that this was introduced
in (#3955, commit 71c4779211), but it
seems to have been missed.

We shouldn't be using this pragma here because it's MSVC specific. This
causes warnings on other compilers.

The test it's surrounding is *extremely* dubious, but for the sake of
silencing warnings on other compilers, we can mark "placebo" as volatile
and be on with it.
 2020-08-03 11:12:55 -04:00
bunnei
3697fc8d14
Merge pull request #4467 from lioncash/mode 
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
 2020-08-03 08:07:56 -07:00
Lioncash
04ca1ed2bd time_zone_binary: Make use of designated initializers 2020-08-03 10:42:38 -04:00
Lioncash
8725b37a35 logging/backend: Make use of designated initializers 
Same behavior, less code.
 2020-08-03 10:37:48 -04:00
Lioncash
9b837c6069 buffer_queue: Make use of std::nullopt 
Allows compilers to eliminate unnecessary zeroing out of the optional's
buffer.
 2020-08-03 09:31:51 -04:00
Lioncash
24bd068a08 buffer_queue: Make use of designated initializers 2020-08-03 09:31:51 -04:00
Lioncash
b9831fd80a profile_manager: Make use of std::nullopt 
Allows some implementations to completely avoid unnecessarily zeroing
out the internal buffer.
 2020-08-03 09:03:42 -04:00
Lioncash
3fcaf937d2 profile_manager: Make use of designated initializers 
More compact code.
 2020-08-03 09:01:31 -04:00
Lioncash
c883666045 dmnt_cheat_vm: Make use of designated initializers 
Allows for more compact code.
 2020-08-03 08:50:51 -04:00
Lioncash
2b8ae009a0 file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode 
Same behavior, minus a hand-rolled operator.
 2020-08-03 07:52:36 -04:00
David Marcec
6a0b77996b sm: Make use of IsBaseOf for GetService 2020-08-03 21:46:14 +10:00
Lioncash
1c6d3ba397 patch_manager: Resolve -Wignored-qualifier warnings 
Top level const will always be ignored in this case, so it can be
removed.
 2020-08-03 07:42:56 -04:00
Lioncash
4ca0014479 registered_cache: Resolve -Wmaybe_uninitialized warnings 
While we're at it, we can avoid a redundant map lookup.
 2020-08-03 07:34:46 -04:00
David Marcec
a5af1161c9 Place in anonymous namespace 2020-08-03 21:31:28 +10:00
David Marcec
6cfff2c3f6 loader: Make IdentifyFile typesafe 
Relies on #4465 for concept.h Common::IsBaseOf
 2020-08-03 21:31:27 +10:00
David
9b75481755
ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465) 
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer

With the support of C++20, we can use concepts to deduce if a type is an STL container or not.

* More agressive concept for stl containers

* Add -fconcepts

* Move to common namespace

* Add Common::IsBaseOf
 2020-08-03 07:28:54 -04:00
David
6c7292de33
Merge pull request #4263 from lat9nq/fix-screencaps-2 
screenshots: Option to save screenshots immediately in a specified directory + Linux workaround
 2020-08-03 21:00:14 +10:00
David
0ca42c806f
Merge pull request #4439 from lioncash/cpu 
cpu_manager: Remove redundant std::function declarations
 2020-08-03 20:58:31 +10:00
David
50d8264833
Merge pull request #4438 from lioncash/localizing 
yuzu/main: Remove redundant usages of QStringLiteral("")
 2020-08-03 20:58:00 +10:00
David Marcec
0947f613b1 mix buffer depopping 2020-08-01 16:25:08 +10:00
Morph
fc86cb4ca2 minor nits 2020-07-31 11:02:59 -04:00
David Marcec
e586921c28 am: Unstub SetScreenShotPermission 2020-08-01 00:44:14 +10:00
Morph
1241020093 fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute 
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
 2020-07-30 15:39:44 -04:00
Morph
45fd67c109 fs: Rename SaveDataDescriptor to SaveDataAttribute 2020-07-30 15:29:39 -04:00
David
0c262f8ac2
Merge pull request #4392 from lioncash/guard 
compatible_formats: Add missing header guard
 2020-07-31 01:08:56 +10:00
David Marcec
1b8fe7073b adpcm streaming 2020-07-30 18:16:57 +10:00
bunnei
4c0f6f1bc8
Merge pull request #4396 from lioncash/comma 
surface_params: Replace questionable usages of the comma operator with semicolons
 2020-07-29 19:55:44 -04:00
Morph
e0d02d032b game_list_worker: Fix game list subdirectory scanning 
Oddly enough the scan that feeds the manual content provider is hardcoded to scan 2 nested directories deep.
This effectively rendered the scan subdirectories setting useless as the manual content provider cannot find any games located more than 2 nested directories deep.
Furthermore, this behavior causes game files to be picked up by the manual content provider even if scan subdirectories is disabled.

FIx this by utilizing the behavior described when populating the game list for populating the content provider.
 2020-07-29 09:22:29 -04:00
Morph
e59d17167d main: Add support for removing SDMC installed titles 2020-07-29 06:50:30 -04:00
Morph
ed46f3c62a xts_archive: Check if the file is nullptr prior to parsing 
Fixes an access violation where the file no longer exists at the specified path while being parsed.
 2020-07-29 06:50:30 -04:00
Morph
2ec852dd9f registered_cache: Add support for removing folder ncas 2020-07-29 06:50:30 -04:00
Morph
b317942131 game_list: Limit context menu options for homebrew 
Hides the following options when the title id is 0:
- Open Save Location
- Open Mod Data Location
- Open Transferable Shader Cache
- All removal options except Remove Custom Configuration
 2020-07-29 06:50:30 -04:00
Morph
cd814bfdfe main: Remove assert for opening savedata when program_id = 0 2020-07-29 06:50:30 -04:00
Morph
f78e44762a main: Silence [[fallthrough]] warning 2020-07-29 06:50:30 -04:00
Morph
ef02370816 main: Split removal cases into their individual functions and address feedback 2020-07-29 06:50:30 -04:00
Morph
85e1facfe6 main: Connect game list remove signals to removal functions 2020-07-29 06:50:30 -04:00
Morph
de6b852dc2 game_list: Add "Remove" context menu 
Adds the following actions:
- Remove Installed Update
- Remove All Installed DLC
- Remove Shader Cache
- Remove Custom Configuration
- Remove All Installed Contents
 2020-07-29 06:50:30 -04:00
bunnei
b205b12e75
Merge pull request #4442 from lioncash/devicemem 
device_memory: Remove unused system member
 2020-07-28 13:03:30 -07:00
Morph
8d42456dc2 configure_graphics: Remove Force 30 FPS mode 
The introduction of multicore rendered this setting non-functional as timing code was changed.

This removes the setting entirely.
 2020-07-28 08:07:26 -04:00
Morph
e8f22730d1 renderer_opengl: Use 1/4 of all threads for async shader compilation 2020-07-28 05:08:27 -04:00
Lioncash
e3f0c93230 common/atomic_ops: Don't cast away volatile from pointers 
Preserves the volatility of the pointers being casted.
 2020-07-28 04:36:53 -04:00
ReinUsesLisp
bc699ace15 service/bsd: Handle Poll with no entries accurately 
Testing shows that Poll called with zero entries returns -1 and signals
an errno of zero.
 2020-07-28 01:51:47 -03:00
ReinUsesLisp
f7d59f3e0e services/bsd: Implement most of bsd:s 
This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName,
GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom,
Send, SendTo, Write, and Close

The implementation was done referencing: SwIPC, switchbrew, testing
with libnx and inspecting its code, general information about bsd
sockets online, and analysing official software.

Not everything from these service calls is implemented, but everything
that is not implemented will be logged in some way.
 2020-07-28 01:48:42 -03:00
ReinUsesLisp
2c67bbf609 service/sockets: Add worker pool abstraction 
Manage worker threads with an easy to use abstraction.
We can expand this to support thread deletion in the future.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
5692c48ab7 service/sockets: Add worker abstraction to execute blocking calls asynchronously 
This abstraction allows executing blocking functions (like recvfrom on a
socket configured for blocking) without blocking the service thread.
It is intended to be used with SleepClientThread.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
80b4bd3583 service/sockets: Add translate functions 
These functions translate from Network enumerations/structures to guest
enumerations/structures and viceversa.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
22263ccaa4 service/sockets: Add enumerations and structures 
Add guest enumerations and structures used in socket services
 2020-07-28 01:47:03 -03:00
ReinUsesLisp
ef8acc9c3d services/nifm: Implement GetCurrentIpAddress 
This is trivially implemented using the Network abstraction

- Used by ftpd
 2020-07-28 01:47:03 -03:00
Lioncash
2258f33ee4 device_memory: Remove unused system member 
This isn't used by anything in particular, so it can be removed.
 2020-07-27 23:37:49 -04:00
Lioncash
989ad52dc1 cpu_manager: Remove redundant std::function declarations 
We can just return the function directly. Making for less reading.
 2020-07-27 21:57:05 -04:00
bunnei
db94457205
Update src/core/hle/service/nvdrv/devices/nvmap.cpp 
Co-authored-by: LC <mathew1800@gmail.com>
 2020-07-27 18:27:20 -07:00
Lioncash
a7af349dae core_timing: Make use of uintptr_t to represent user_data 
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
 2020-07-27 21:21:01 -04:00
Lioncash
2e303095d5 yuzu/main: Remove redundant usages of QStringLiteral("") 
An empty QStringLiteral can more efficiently be replaced with an empty
QString.
 2020-07-27 21:04:17 -04:00
bunnei
6b35317ff3
Merge pull request #4419 from lioncash/initializer 
vulkan: Resolve -Wmissing-field-initializer warnings
 2020-07-27 15:52:03 -07:00
bunnei
f97c2cdd0b
Merge pull request #4434 from CrazyMax/lang_unused_var 
AM: GetDesiredLanguage: remove unused variable
 2020-07-27 12:37:52 -07:00
Rodrigo Locatti
d51afc4efb
Merge pull request #4432 from bylaws/patch-1 
video_core/gpu: Correct the size of the puller registers
 2020-07-27 05:25:49 -03:00
CrazyMax
1ffff4dab2 remove unused variable; 2020-07-27 10:36:26 +03:00
bunnei
99d191d80d
Merge pull request #4431 from kelnos/fix-exit-crash 
GCAdapter: only join worker thread if running & joinable
 2020-07-26 18:03:37 -07:00
Brian J. Tarricone
d840ed90e1 GCAdapter: only join worker thread if running & joinable 2020-07-26 14:54:02 -07:00
Billy Laws
f490b4545d
video_core/gpu: Correct the size of the puller registers 
The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.
 2020-07-26 22:26:29 +01:00
lat9nq
156bf5b297 config: Make the save-as identifier more consistent 
Solves an issue with restoring the value upon reloading program.
 2020-07-26 13:31:00 -04:00
bunnei
08f02836d8
Merge pull request #4426 from lioncash/lock 
nvflinger: Use return value of Lock()
 2020-07-26 09:19:24 -07:00
bunnei
4524e1bd54
Merge pull request #4418 from lioncash/udp-warn 
udp/client: Remove unused boost include
 2020-07-25 21:50:37 -07:00
bunnei
05def61398 hle: nvdrv: Rewrite of GPU memory management. 2020-07-26 00:49:43 -04:00
bunnei
45cf48bd0a
Merge pull request #4415 from lioncash/maybe 
virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]]
 2020-07-25 21:35:09 -07:00
bunnei
b69f902b18
Merge pull request #4417 from lioncash/poll 
gc_adapter/gc_poller: Resolve compiler warnings
 2020-07-25 19:42:09 -07:00
FearlessTobi
35b96a28d7 yuzu/configure_debug: Remove duplicated checkboxes 
Those are already found in the Filesystem tab.
They were added back to the Debug tab by mistake in the Vulkan PR.
 2020-07-26 02:45:19 +02:00
Lioncash
7b070bbf62 nvflinger: Mark interface functions with return values as [[nodiscard]] 
Not using the return value of these functions are undeniably the source
of a bug. This way we allow compilers to loudly make any future misuses
evident.
 2020-07-25 19:42:45 -04:00
Lioncash
5dab23e017 nvflinger: Use return value of Lock() 
comex reported in #4424 that we were incorrectly discarding the return
value of Lock() which is correct.
 2020-07-25 19:04:53 -04:00
bunnei
a2e1810287
Merge pull request #4350 from ogniK5377/hid-update-connected 
hid: Only update keyboard & debug pad inputs if enabled
 2020-07-25 11:57:24 -07:00
LC
e3503de588
common/string_util: Remove unimplemented function prototype (#4414) 
This function was relocated to log.h as a constexpr function, so this
can be removed.
 2020-07-25 15:37:51 +02:00
David Marcec
3dcbba38bf Fix perf regression 2020-07-25 21:46:25 +10:00
Lioncash
80eedff9e1 vulkan: Resolve -Wmissing-field-initializer warnings 2020-07-25 03:50:18 -04:00
Lioncash
1a7cf26884 udp/client: Remove unused boost include 
Also silences a deprecation warning from boost on Clang/GCC.
 2020-07-25 03:42:03 -04:00
Lioncash
ac7e4e2cab gc_adapter: Resolve C++20 deprecation warning 2020-07-25 03:38:22 -04:00
Lioncash
04699c366b gc_poller: Resolve -Wsign-compare warning 2020-07-25 03:37:22 -04:00
Lioncash
e19972dfc4 gc_poller: Resolve -Wredundant-move warning 2020-07-25 03:35:40 -04:00
Lioncash
2e511246fa lz4_compression: Make use of std::span in interfaces 
Allows compressing the data and size parameters into one.
 2020-07-25 03:17:04 -04:00
Lioncash
c5bdccfecb zstd_compression: Make use of std::span in interfaces 
Allows condensing the data and size parameters into a single argument.
 2020-07-25 03:11:56 -04:00
Lioncash
ca6ff01333 virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]] 
This isn't used on Windows, but is used on non-Windows operating
systems.
 2020-07-25 03:04:27 -04:00
bunnei
d046e9b458
Merge pull request #4380 from ogniK5377/swkbd-inline-1 
swkbd: Return result for Calc request for inlined swkbd
 2020-07-24 22:31:24 -07:00
bunnei
dc2d31b1b2
Merge pull request #4393 from lioncash/unused5 
vk_rasterizer: Remove unused variable in Clear()
 2020-07-24 20:33:58 -07:00
David Marcec
f4eb7dceaf Fix stream channel count when outputting to stereo 2020-07-25 13:31:43 +10:00
David Marcec
b924c71822 Address issues 2020-07-25 12:39:37 +10:00
David Marcec
8a497adf85 Queue extra mix buffer 2020-07-25 12:39:36 +10:00
David Marcec
d68856ab12 Disable time stretcher for time being 2020-07-25 12:39:35 +10:00
David Marcec
380658c21d audio_core: Apollo Part 1, AudioRenderer refactor 2020-07-25 12:39:34 +10:00
bunnei
c73701edea
Merge pull request #4377 from Morph1984/dark-themes 
qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1)
 2020-07-24 19:23:45 -07:00
bunnei
2ed8f3f549
Merge pull request #4334 from lat9nq/clear-per-game-settings 
configure_per_game: Clearer per-game settings
 2020-07-24 19:19:27 -07:00
bunnei
d488cb843e
Merge pull request #4388 from lioncash/written 
buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()
 2020-07-24 11:29:37 -07:00
bunnei
f650cf8a9a
Merge pull request #4391 from lioncash/nrvo 
video_core: Allow copy elision to take place where applicable
 2020-07-24 06:33:09 -07:00
bunnei
1d7de0a8ee
Merge pull request #4394 from lioncash/unused6 
video_core: Remove unused variables
 2020-07-23 19:54:59 -07:00
bunnei
5ac91a6c7a
Merge pull request #4353 from ameerj/gc-refactor 
gc_adapter: Refactor code
 2020-07-23 18:44:39 -07:00
Jan Beich
f99be1c923 network: add missing include for BSDs 
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD'
constexpr int SD_RECEIVE = SHUT_RD;
                           ^
src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR'
constexpr int SD_SEND = SHUT_WR;
                        ^
src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR'
constexpr int SD_BOTH = SHUT_RDWR;
                        ^
src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'?
constexpr IPv4Address TranslateIPv4(in_addr addr) {
                                    ^~~~~~~
                                    in_addr_t
/usr/include/netdb.h:66:20: note: 'in_addr_t' declared here
typedef __uint32_t      in_addr_t;
                        ^
src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union
    const u32 bytes = addr.s_addr;
                      ~~~~^~~~~~~
src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized
    const u32 bytes = addr.s_addr;
              ^
src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition
sockaddr TranslateFromSockAddrIn(SockAddrIn input) {
         ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'?
    sockaddr_in result;
    ^~~~~~~~~~~
    sockaddr
/usr/include/netdb.h:142:9: note: 'sockaddr' declared here
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr'
    sockaddr_in result;
                ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons'
    result.sin_port = htons(input.portno);
                      ^
src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr'
    sockaddr addr;
             ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:156:1: error: unknown type name 'linger'
linger MakeLinger(bool enable, u32 linger_value) {
^
src/core/network/network.cpp:157:5: error: unknown type name 'linger'
    linger value;
    ^
src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET'
        return AF_INET;
               ^
src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM'
        return SOCK_STREAM;
               ^
src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM'
        return SOCK_DGRAM;
               ^
src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP'
        return IPPROTO_TCP;
               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
 2020-07-22 22:10:15 +00:00
David Marcec
8abb31a19d vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo 
Needed for dark souls and monster hunter
 2020-07-21 23:06:18 +10:00
Rodrigo Locatti
7278c59d70
Merge pull request #4359 from ReinUsesLisp/clamp-shared 
renderer_{opengl,vulkan}: Clamp shared memory to host's limit
 2020-07-21 04:51:05 -03:00
Rodrigo Locatti
721e6015a8
Merge pull request #4360 from ReinUsesLisp/glasm-bar 
gl_arb_decompiler: Execute BAR even when inside control flow
 2020-07-21 04:50:55 -03:00
Rodrigo Locatti
9ea9a60e17
Merge pull request #4361 from ReinUsesLisp/lane-id 
decode/other: Implement S2R.LaneId
 2020-07-21 04:50:45 -03:00
Lioncash
82b7e5c8ee surface_params: Make use of designated initializers where applicable 
Provides a convenient way to avoid unnecessary zero initializing.
 2020-07-21 02:27:22 -04:00
Lioncash
bd9545a3a8 surface_params: Remove redundant assignment 
This is a redundant assignment that can be removed.
 2020-07-21 02:26:49 -04:00
Lioncash
c705a1db96 surface_params: Replace questionable usages of the comma operator with semicolons 
These are bugs waiting to happen.
 2020-07-21 02:26:48 -04:00
David
e9bfe05e04
Merge pull request #4306 from ReinUsesLisp/bsd-network 
core/network: Add network abstraction
 2020-07-21 16:05:47 +10:00
Lioncash
e17fb5ee97 video_core: Remove unused variables 
Silences several compiler warnings about unused variables.
 2020-07-21 00:57:25 -04:00
Lioncash
4b369126c4 vk_rasterizer: Remove unused variable in Clear() 
The relevant values are already assigned further down in the lambda, so
this can be removed entirely.
 2020-07-21 00:49:10 -04:00
Lioncash
059305a6bf compatible_formats: Add missing header guard 
Prevents potential inclusion issues from occurring.
 2020-07-21 00:42:19 -04:00
Lioncash
6adc824d9d video_core: Allow copy elision to take place where applicable 
Removes const from some variables that are returned from functions, as
this allows the move assignment/constructors to execute for them.
 2020-07-21 00:36:13 -04:00
bunnei
3d13d7f48f
Merge pull request #4324 from ReinUsesLisp/formats 
video_core: Fix, add and rename pixel formats
 2020-07-21 00:13:04 -04:00
lat9nq
e35239b861 configure_ui: Ensure a separator follows the returned path 2020-07-20 23:19:07 -04:00
lat9nq
19250aadee configure_ui: don't use an empty string 
If the user had cancelled, it would clear the text box. That behavior was sanitized underneath, but may anyways cause inconveniences.
 2020-07-20 23:11:46 -04:00
lat9nq
599b7c26a9 main: Don't use as many string copies 
Co-Authored-By: LC <lioncash@users.noreply.github.com>
 2020-07-20 23:03:55 -04:00
lat9nq
a723ed31fd main: rewrite (save as) screenshot saving 
This picks a default directory and file name. If on Windows and save-as screenshot saving is enabled, it asks the user, first defaulting to the default screenshot path, and with a default filename in the format `[title_id]_[year-mt-dy_hr-mn-sc-msc].png`. Otherwise, or on Linux for now, it simply saves a file in that directory with that file name.
 2020-07-20 23:03:55 -04:00
lat9nq
71b902cf62 configuration: Setup UI to config screenshot path and saving 
This adds two options to the General -> UI tab. The first disables picking a place to save the file. The second chooses a default directory for saving screenshots.
 2020-07-20 23:03:49 -04:00
lat9nq
3848155c42 common: Add a screenshots directory 
Adds a screenshots directory as a path managed by FileUtil.
 2020-07-20 22:51:02 -04:00
David Marcec
dd4a02d15c video_core: Remove redundant pixel format type 
We already get the format type before converting shadow formats and during shadow formats.
 2020-07-21 12:44:32 +10:00
bunnei
61e4c0f83d
Merge pull request #4168 from ReinUsesLisp/global-memory 
gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders
 2020-07-20 21:54:17 -04:00
Lioncash
26c6c71837 buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten() 
We can make use of emplace()'s return value to determine whether or not
we need to perform an increment.

emplace() performs no insertion if an element already exist, so this can
eliminate a find() call.
 2020-07-20 17:48:00 -04:00
Morph
d942472cce wait_tree: Include Midnight Blue dark themes 2020-07-20 01:25:25 -04:00
James Rowe
7e01311061 qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1) 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-07-20 01:25:25 -04:00
David Marcec
8248d76964 Address issues 2020-07-20 11:52:07 +10:00
lat9nq
2120740ee6 configure_graphics_advnaced: clang-format mk ii 2020-07-19 13:26:55 -04:00
lat9nq
23347b8869 configure_graphics_advanced: Fix oversight from rebase 2020-07-19 13:26:55 -04:00
lat9nq
520b4c7829 configuration_shared: Remove unused functions 
These were only kept for compatibility with old code during testing.
 2020-07-19 13:26:55 -04:00
lat9nq
3ef4769f31 configuration: Use forward declares and remove extraneous structs 2020-07-19 13:26:55 -04:00
lat9nq
335aef78c4 configuration_shared: Make CheckState strongly typed 
Also gets rid of unnecessary explicit namespace usage.
 2020-07-19 13:26:55 -04:00
lat9nq
55ac28769a clang-format 2020-07-19 13:26:55 -04:00
lat9nq
0d462f5608 configuration_shared: Break up tracker structs to respective classes 
One less global variable.
 2020-07-19 13:26:55 -04:00
lat9nq
e483ed21eb configure_system: break instead of semicolon 
Makes the code more readable

Co-Authored-By: LC <lioncash@users.noreply.github.com>
 2020-07-19 13:26:55 -04:00
lat9nq
d5fdbd88c8 clang-format 2020-07-19 13:26:55 -04:00
lat9nq
33a9218f35 configure_system: Highlight labels on startup 
whoops
 2020-07-19 13:26:55 -04:00